mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
442 stars 103 forks source link

Multiple Mozilla VPN instances are opened #9191

Open data-sync-user opened 4 months ago

data-sync-user commented 4 months ago

Important details:

Version/build found in:

Reproducible on:

Prerequisites:

Steps to reproduce:

  1. Open the app and log in with account from prerequisites;
  2. Go to tray-bar and quit the app;
  3. Go to device Start menu, search for Mozilla VPN and click multiple times to open the app.

Expected result:

Actual result:

┆Issue is synchronized with this Jira Bug ┆Reporter: Valentina Virlics

data-sync-user commented 4 months ago

➤ Valentina Virlics commented:

We encountered this while performing a “quit” action from tray-bar menu, and reopening multiple times the client.

This new behavior is not related with the Reset feature.

Attaching video with the new steps to repro this.

!multiple.mp4|width=1280,height=756!

data-sync-user commented 3 months ago

➤ Valentina Virlics commented:

After further investigation, this ticket has nothing to do with the Reset and Quit feature. Removing the related epic/task.

data-sync-user commented 3 months ago

➤ Santiago Andrigo commented:

I just installed version 2.21.0 (2.202403141450) for Windows 11, and I can’t reproduce, with or without using the “Reset and Quit” action. Maybe it’s not deterministic and there is something else at play?

Overall, this is not something that affects neither security nor usability, and it takes the user consciously trying to open the app more than once, which is not something that happens by chance. Given this, I’m OK keeping this in Medium (leaning on Low, to be honest).

data-sync-user commented 3 months ago

➤ Valentina Virlics commented:

You just need to click 2 times the Mozilla VPN icon from Start => you should reproduce it.

If for some reason user device works slow or the client does not open instantly (as for my case), it is very easy to encounter it.

!15.03.2024_17.25.35_REC.mp4|width=1280,height=678!

Based on the fact that it is easy to repro and that is bad/confusing user experience to have multiple instances, I’ll vote for High. But ultimately, is not my call.

data-sync-user commented 3 months ago

➤ Valentina Virlics commented:

Lesley Norton Santiago Andrigo Matt Cleinman Shouldn't we include this in the RC? Thanks!

data-sync-user commented 3 months ago

➤ Santiago Andrigo commented:

It’d be problematic because …

So trying to squeeze this would go against our stated policy about uplifts and, in this case, delay the release of other goodies just for this.

data-sync-user commented 3 months ago

➤ Valentina Virlics commented:

This is currently reproducing while on the latest 2..22 build, on both Windows 10 and 11.

Steps to reproduce:

!image_2024_04_05T12_50_33_178Z.png|width=775,height=742,alt="image_2024_04_05T12_50_33_178Z.png"!

data-sync-user commented 1 month ago

➤ Valentina Virlics commented:

This is currently happening on 2.23 as well.