search

mozilla-mobile / perf-frontend-issues

A repository to hold issues related to front-end mobile application performance.
4 stars 0 forks source link

Replace example.com as test site in VIEW perftest (maybe FNPRMS) #178

Closed mcomella closed 3 years ago

mcomella commented 3 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1670247

We can use our own github.io instead, given we pay for that organization and thus the hosting and these sites are generally reliable.

We could consider changing it in FNPRMS too but it'll affect the results (since it does a full page load) and we're moving away from FNPRMS anyway.

mcomella commented 3 years ago

Moving to waiting: we're going to wait until https://github.com/mozilla-mobile/fenix/issues/17447 is done before landing to minimize the number of variables.

mcomella commented 3 years ago

I'd like to get some wins first so let's move this to the backlog.

mcomella commented 3 years ago

Actually, there's an r+'d patch so we're just waiting for our "improvement" alert in the perftest dashboard.

mcomella commented 3 years ago

This landed upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1670247#c12

Let's keep this open to make sure we're still getting reasonable data from perftest.

mcomella commented 3 years ago

We still have the 500 error from perftest but it seems unrelated to this change. I think this change was safe and we can close this issue.