search

mozilla-mobile / perf-frontend-issues

A repository to hold issues related to front-end mobile application performance.
4 stars 0 forks source link

Add Pixel 2 measurements to FNPRMS #57

Closed mcomella closed 4 years ago

mcomella commented 4 years ago

Our release criteria specifies we should validate performance on high-end and low-end reference devices: we should add the Pixel 2, our high-end reference device.

hawkinsw commented 4 years ago

I've wanted to be able to have FNPRMS target different devices for a while, so this would be a good driver for that work. In fact, right now FNPRMS assumes that there is only a single device attached to the system when it is run. If there is more than one, it will fail (or potentially run on what adb thinks is the default device -- I haven't tried, to be honest).

mcomella commented 4 years ago

it will fail (or potentially run on what adb thinks is the default device -- I haven't tried, to be honest).

iirc, it fails. You can specify a device with adb -s <DEVICE-SERIAL-NUMBER> <command>.

mcomella commented 4 years ago

Triage: Eric wants to follow up with more data before we prioritize this issue.

hawkinsw commented 4 years ago

On Mon, Jan 13, 2020, 9:57 PM Michael Comella notifications@github.com wrote:

it will fail (or potentially run on what adb thinks is the default device -- I haven't tried, to be honest).

iirc, it fails. You can specify a device with adb -s

.

Yup, that's the one! I was just saying that it's not currently handled in the code right now.

(edited for tone!)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mozilla-mobile/perf-frontend-issues/issues/57?email_source=notifications&email_token=ACCP2CXTEP3J76PY3VQU5B3Q5US2NA5CNFSM4KFPLW2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI3C3QQ#issuecomment-573976002, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCP2CQLAWCRKAAMXFSQ4N3Q5US2NANCNFSM4KFPLW2A .

mcomella commented 4 years ago

FNPRMS is currently hard-coded to download armv7 builds so we should make sure to change that when adding support for other devices.

mcomella commented 4 years ago

Dupe #66.