Closed antlam closed 8 years ago
Notes from Emily's comments on my branch:
As no one will be able to see any interactivity on the map,
I feel like having an accurate map in the carousel is important but maybe we can snapshot it and replace the mapview with the snapshot while the places view is open.
@antlam How tall should the review branding logos be?
How tall should the review branding logos be?
via slack: they should be the native image size.
Shadow params via slack:
box-shadow: 0px 2px 5px 0px rgba(0,0,0,0.40);
border-radius: 10px;
Things still to do (post #91):
And from Emily via slack:
@mcomella website link is clickable, it just needs to be underlined. You can do that with NSAttributedString
like this (although this is Swift 2.3 code so it would need to be Swift 3.0-ified):
let underlineAttribute = [NSUnderlineStyleAttributeName: NSUnderlineStyle.StyleSingle.rawValue]
let underlineAttributedString = NSAttributedString(string: "StringWithUnderLine", attributes: underlineAttribute)
myLabel.attributedText = underlineAttributedString
I implemented or put all the remaining work into new bugs blocking the Sprint #3 milestone (using the milestone helped me make sense of the numerous github issues). By the end of the day, I should transform these into trello cards too.