mozilla-mobile / prox

[INACTIVE] A search and discovery app for the "here & now". We're experimenting with ideas on mobile that can better surface content from the open web.
https://wiki.mozilla.org/New_Mobile_Experience
Mozilla Public License 2.0
22 stars 12 forks source link

Implement Home View #11

Closed antlam closed 8 years ago

antlam commented 8 years ago

apple iphone 7 silver

antlam commented 8 years ago

Sizes

sizes


Spacing

spacing


Properties

properties


fluffyemily commented 8 years ago
fluffyemily commented 8 years ago

I want to receive an actionable overview of relevant information about places near me, so that my day is not ruined with FOMO

mcomella commented 8 years ago

Notes from Emily's comments on my branch:

mcomella commented 8 years ago

As no one will be able to see any interactivity on the map,

I feel like having an accurate map in the carousel is important but maybe we can snapshot it and replace the mapview with the snapshot while the places view is open.

mcomella commented 8 years ago

@antlam How tall should the review branding logos be?

antlam commented 8 years ago

MVP_assets.zip

mcomella commented 8 years ago

How tall should the review branding logos be?

via slack: they should be the native image size.

mcomella commented 8 years ago

Shadow params via slack:

box-shadow: 0px 2px 5px 0px rgba(0,0,0,0.40);
border-radius: 10px;
mcomella commented 8 years ago

Things still to do (post #91):

And from Emily via slack:

fluffyemily commented 8 years ago

@mcomella website link is clickable, it just needs to be underlined. You can do that with NSAttributedString like this (although this is Swift 2.3 code so it would need to be Swift 3.0-ified):

let underlineAttribute = [NSUnderlineStyleAttributeName: NSUnderlineStyle.StyleSingle.rawValue]
let underlineAttributedString = NSAttributedString(string: "StringWithUnderLine", attributes: underlineAttribute)
myLabel.attributedText = underlineAttributedString
mcomella commented 8 years ago

I implemented or put all the remaining work into new bugs blocking the Sprint #3 milestone (using the milestone helped me make sense of the numerous github issues). By the end of the day, I should transform these into trello cards too.