search

mozilla-mobile / prox

[INACTIVE] A search and discovery app for the "here & now". We're experimenting with ideas on mobile that can better surface content from the open web.
https://wiki.mozilla.org/New_Mobile_Experience
Mozilla Public License 2.0
22 stars 12 forks source link

Clicking map button freezes app #518

Closed mcomella closed 7 years ago

mcomella commented 7 years ago

I briefly looked into this – if you change PlaceDetailViewController.close to self.dismiss(animated: false), a white screen will appear rather than the app freezing. I opened the UI hierarchy debugger and it appears that the white screen doesn't appear at all:

screen shot 2017-02-13 at 13 27 15

Due to how the animation change affects this issue, I think this may be an animation issue.

If not, I think this may have happened after Brian updated to the new schema, which was missing place information – perhaps the missing information is the cause? (e.g. we silently fail with the missing data?)

Anyway, this isn't super important because we're likely removing this view so I'll go work on something else.

mcomella commented 7 years ago

There is also this ambiguous layout issue:

screen shot 2017-02-13 at 13 30 06
thebnich commented 7 years ago

Fixed by #523.