mozilla-mobile / prox

[INACTIVE] A search and discovery app for the "here & now". We're experimenting with ideas on mobile that can better surface content from the open web.
https://wiki.mozilla.org/New_Mobile_Experience
Mozilla Public License 2.0
22 stars 12 forks source link

Implement search when panning in Map View #563

Closed brampitoyo closed 7 years ago

brampitoyo commented 7 years ago

prox-search-move-i04

When the user pans around the Map View:

When tapped, a search is performed around the selected radius:

When search has been performed:

mcomella commented 7 years ago

For Chicago, we likely won't have time to update the Details card view screen with the new list of places. I've mentioned this to Anthony on Slack and he seemed okay with it. Chenxia mentioned that, when we close the map view, we can pan back to the user's current location so it isn't jarring that the place list doesn't represent the new location.

mcomella commented 7 years ago

Thought: search in other places won't find anything because we only have hand-curated Discover places for downtown. Solutions:

brampitoyo commented 7 years ago

when we close the map view, we can pan back to the user's current location so it isn't jarring that the place list doesn't represent the new location.

Good idea. The animation should be identical to the one that happens when you tap “Return to my location”. Except at the end of it, we animate out the map view, revealing the home view underneath.

mcomella commented 7 years ago

@antlam What should the dialog text be, the one that says, "We don't yet support searching in this area"?

Note to self: just do this when place count is 0.

antlam commented 7 years ago

@mcomella for Chicago, let's go with "No results for this area yet"

Instead of just "Dismiss" as the action. Can we also offer a "Reset" action? That way, the user can re-center from the dialog screen. But only if it's easy!

brampitoyo commented 7 years ago

Button specs:

2

mcomella commented 7 years ago

316px from top of the inner map circle

The of the circle width is variable by device width and we set the height to equal the width so this won't work. I'm setting the buttons center Y to the bottom-most point in the circle, atm.

brampitoyo commented 7 years ago

I'm setting the buttons center Y to the bottom-most point in the circle, atm.

This is a more correct and elegant approach to positioning. I didn’t realise that we can do it dynamically!