mozilla-mobile / reference-browser

A full-featured browser reference implementation using Mozilla Android Components.
Mozilla Public License 2.0
563 stars 160 forks source link

Re-enable Detekt and fix up newly-found issues #2794

Closed rvandermeulen closed 2 months ago

rvandermeulen commented 2 months ago

Turns out we accidentally disabled it across most of the repo around the time we bumped to version 1.22. Whoopsie. This PR re-enables it, updates Detekt to the latest version, and fixes up, suppresses, or baselines the new issues that are now being caught. As a bonus, I removed some suppressions which don't appear to be necessary anymore and refactored away another one.