search

mozilla-mobile / reference-browser

A full-featured browser reference implementation using Mozilla Android Components.
Mozilla Public License 2.0
584 stars 167 forks source link

Crash on start on Pixel 2 #324

Closed yoasif closed 5 years ago

yoasif commented 5 years ago

Downloaded nightly build (taskid IC4_jMOdRrWXNjUO9QoTQQ).

The browser starts up, shows a filled in URL (session restore) and crashes immediately after without loading a page. Unsure how to get debug information to provide additional details.

Running the December 2018 Android 9 update for Pixel 2.

jamienicol commented 5 years ago

I am hitting a crash too. I compiled my own geckoview and got this backtrace:

art_sigsegv_fault 0x00000000eba3aa70
art::FaultManager::HandleFault(int, siginfo*, void*) 0x00000000eba3adc8
<unknown> 0x00000000aec5c0d4
<unknown> 0x00000000ec3239d8
void mozilla::jni::Accessor::EndAccess<mozilla::java::GeckoSession::Compositor::RecvToolbarAnimatorMessage_t>(mozilla::java::GeckoSession::Compositor::RecvToolbarAnimatorMessage_t::Owner::Context const&, nsresult*) Accessors.h:55
mozilla::jni::Method<mozilla::java::GeckoSession::Compositor::RecvToolbarAnimatorMessage_t, bool>::EndAccess(mozilla::jni::Context<mozilla::java::GeckoSession::Compositor, _jobject*> const&, nsresult*) Accessors.h:93
void mozilla::jni::Method<mozilla::java::GeckoSession::Compositor::RecvToolbarAnimatorMessage_t, void>::Call<int>(mozilla::jni::Context<mozilla::java::GeckoSession::Compositor, _jobject*> const&, nsresult*, int const&) Accessors.h:141
mozilla::java::GeckoSession::Compositor::RecvToolbarAnimatorMessage(int) const GeneratedJNIWrappers.cpp:2497
nsWindow::LayerViewSupport::RecvToolbarAnimatorMessage(int) nsWindow.cpp:1059
nsWindow::RecvToolbarAnimatorMessageFromCompositor(int) nsWindow.cpp:2156
mozilla::layers::UiCompositorControllerChild::RecvToolbarAnimatorMessageFromCompositor(int const&) UiCompositorControllerChild.cpp:233
mozilla::layers::PUiCompositorControllerChild::OnMessageReceived(IPC::Message const&) PUiCompositorControllerChild.cpp:398
mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) MessageChannel.cpp:2159
mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) MessageChannel.cpp:2086
mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) MessageChannel.cpp:1935
mozilla::ipc::MessageChannel::MessageTask::Run() MessageChannel.cpp:1966
mozilla::RunAndroidUiTasks() AndroidUiThread.cpp:331
GeckoThreadSupport::RunUiThreadCallback() nsAppShell.cpp:234
long long mozilla::jni::NativeStub<mozilla::java::GeckoThread::RunUiThreadCallback_t, GeckoThreadSupport, mozilla::jni::Args<> >::Wrap<&(GeckoThreadSupport::RunUiThreadCallback())>(_JNIEnv*, _jclass*) Natives.h:689
art_quick_generic_jni_trampoline 0x00000000ebd0ca7a
art_quick_invoke_stub_internal 0x00000000ebd08576
art_quick_invoke_static_stub 0x00000000ebce1c7e
art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*) 0x00000000eb99c02a
art::interpreter::ArtInterpreterToCompiledCodeBridge(art::Thread*, art::ArtMethod*, art::ShadowFrame*, unsigned short, art::JValue*) 0x00000000ebae0aec
bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebadb5da
bool art::interpreter::DoInvoke<(art::InvokeType)0, false, false>(art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebb04400
void art::interpreter::ExecuteSwitchImplCpp<false, false>(art::interpreter::SwitchImplContext*) 0x00000000ebb01440
ExecuteSwitchImplAsm 0x00000000ebd0d456
art::interpreter::Execute(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame&, art::JValue, bool) (.llvm.2471763592) 0x00000000ebabfd1a
art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*) 0x00000000ebac443c
bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebadb5c2
bool art::interpreter::DoInvoke<(art::InvokeType)4, false, false>(art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebb03bae
void art::interpreter::ExecuteSwitchImplCpp<false, false>(art::interpreter::SwitchImplContext*) 0x00000000ebafe3dc
ExecuteSwitchImplAsm 0x00000000ebd0d456
art::interpreter::Execute(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame&, art::JValue, bool) (.llvm.2471763592) 0x00000000ebabfd1a
art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*) 0x00000000ebac443c
bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebadb5c2
bool art::interpreter::DoInvoke<(art::InvokeType)0, false, false>(art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebb04400
void art::interpreter::ExecuteSwitchImplCpp<false, false>(art::interpreter::SwitchImplContext*) 0x00000000ebb01440
ExecuteSwitchImplAsm 0x00000000ebd0d456
art::interpreter::Execute(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame&, art::JValue, bool) (.llvm.2471763592) 0x00000000ebabfd1a
art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*) 0x00000000ebac443c
bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebadb5c2
bool art::interpreter::DoInvoke<(art::InvokeType)2, false, false>(art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebb022de
void art::interpreter::ExecuteSwitchImplCpp<false, false>(art::interpreter::SwitchImplContext*) 0x00000000ebb008a4
ExecuteSwitchImplAsm 0x00000000ebd0d456
art::interpreter::Execute(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame&, art::JValue, bool) (.llvm.2471763592) 0x00000000ebabfd1a
art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*) 0x00000000ebac443c
bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*) 0x00000000ebadb5c2
MterpInvokeStatic 0x00000000ebcdd7b2
ExecuteMterpImpl 0x00000000ebcfb498
art::interpreter::Execute(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame&, art::JValue, bool) (.llvm.2471763592) 0x00000000ebabfd56
art::interpreter::EnterInterpreterFromEntryPoint(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*) 0x00000000ebac4382
artQuickToInterpreterBridge 0x00000000ebcd02bc
art_quick_to_interpreter_bridge 0x00000000ebd0cb02
art_quick_instrumentation_entry 0x00000000ebd0cbf0
<unknown> 0x00000000ebaf4cb0
<unknown> 0x0000000073593e28

I bisected, and found the following commit caused the crash: https://hg.mozilla.org/mozilla-central/rev/73385b831880

If I revert that, then my reference-browser build does not crash.

sling-shot commented 5 years ago

I see similar crash on start. I had installed the APK on 08th December. The app seems to start shows a page with addressbar showing https://mozilla.org and then crashes. The actual webpage is not displayed.

I am using Sony Xperia XZ1 Dual handset running Android 9.0 security patch level Nov 1. Build number 47.2.A.2.33.

st3fan commented 5 years ago

@jamienicol @sling-shot Thank you so much for giving this a try - would you mind grabbing the most recent APK and test again?

We are in the process of working towards a first stable build that we know is good to test with. Keep an eye on the README - we will put in a link to a stable APK next to the nightly builds.

yoasif commented 5 years ago

I just tried the latest APK and am still hitting a crash.

st3fan commented 5 years ago

Ok hold on - I think we fixed the root cause but may not have updated the reference browser to pick this up.

jamienicol commented 5 years ago

Still crashing for me too. Out of interest, what was the change that was supposed to fix it?

Good news about the stable apk. I'm actually more interested in running nightly or with my own local gecko build, as I'm using this to dogfood webrender work :smile:

jamienicol commented 5 years ago

Tested with a local build of mozilla-central and it works perfectly! :+1: So yes, must just need an update. Thanks!

csadilek commented 5 years ago

Hey everyone,

We just landed another fix for this. So, tomorrow's Nightly should no longer crash on startup. Once ready you can get it from here: https://tools.taskcluster.net/index/project.mobile.reference-browser.nightly/latest