search

mozilla-mobile / telemetry-ios

A generic library for sending telemetry pings from iOS applications to Mozilla's telemetry service.
Mozilla Public License 2.0
28 stars 23 forks source link

Sentry reporting proxy errors (error 310), ensure handled properly #73

Closed garvankeeley closed 7 years ago

garvankeeley commented 7 years ago

I see this in Sentry: Error Domain=kCFErrorDomainCFNetwork Code=310 "(null)" UserInfo={_kCFStreamErrorCodeKey=-2096, _kCFStreamErrorDomainKey=4}

garvankeeley commented 7 years ago

TelemetryClient.upload will not treat this as an HTTP response code, it correctly tries to cast the NSError to an HTTPURLResponse:

let httpResponse = response as? HTTPURLResponse
let statusCode = httpResponse?.statusCode ?? 0

For beta 7474 I see 3 of these 310 errors reported. We would need the Telemetry client GUID reported along with the NSError to sentry in order to possibly correlate this error with missing ping sequences.

garvankeeley commented 7 years ago

Closing, no bug here.