search

mozilla-mobile / telemetry-ios

A generic library for sending telemetry pings from iOS applications to Mozilla's telemetry service.
Mozilla Public License 2.0
28 stars 23 forks source link

telemetry-key-prefix-mobile-event-dailyUploadCount is larger than limit #96

Closed st3fan closed 6 years ago

st3fan commented 6 years ago

Probably related to #95. I grabbed Fennec's App Container and when I look in the preferences.plist, I see this:

telemetry-key-prefix-mobile-event-dailyUploadCount: 103
telemetry-key-prefix-core-dailyUploadCount: 103

This should not be possible since MaxNumberOfPingUploadsPerDay is set to 100.

justindarc commented 6 years ago

This is also a dupe of #94. When a day passes since the last ping was sent, at least one ping will get uploaded. Afterwards, we'll increment the upload count before checking if we've exceeded the MaxNumberOfPingUploadsPerDay threshold. This is how that value is exceeding the threshold (it is not checked until after the first ping is uploaded).