search

mozilla-platform-ops / monopacker

builds taskcluster worker images for AWS and GCP using packer
Mozilla Public License 2.0
6 stars 9 forks source link

Bug 1808534 - Sync FxCI GCP monopacker config #104

Closed MasterWayZ closed 1 year ago

MasterWayZ commented 1 year ago

We no longer put the L3 images into its own project.

community-tc-integration[bot] commented 1 year ago
No Taskcluster jobs started for this pull request ```js The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the default branch) does not allow starting tasks for this pull request. ```
MasterWayZ commented 1 year ago

It is not documented but dhouse and I have been doing this for a while. Dhouse informed me that security agreed (if not then talk to him) as it will allow us to hopefully use one image in the future and load in the secrets in a different way, but that's a future thing.

hwine commented 1 year ago

Thanks @petemoore for the ping!

It is not documented but

Please find a good spot to document it -- maybe near a discussion of the CoT key insertion? As Pete noted, this looks-funny-on-the-surface, so is worthy of a chat

Dhouse informed me that security agreed (if not then talk to him) as it will allow us to hopefully use one image in the future and load in the secrets in a different way, but that's a future thing.

@dhouse - we can handle this on email, but I'm not up to speed on this. I'll start a thread.

MasterWayZ commented 1 year ago

Re-requested review: I have added some extra code, as some of Matt's commits to main broke GCP image creation. My code is a bit of an attempt to try to make sure we can use both without putting the current worker images upside-down.

MasterWayZ commented 1 year ago

Fair warning; I did not test this for AWS nor community. Someone should test those first before merging this.

MasterWayZ commented 1 year ago

Latest is https://github.com/taskcluster/monopacker/commit/3d43fa49ad2ea68f93c6dfe2d05daa536af278ae We opted to move the images back to the L3 project, so this reverts that change. It also adds some logic and other bits and pieces to make the Ubuntu 18 FxCI workers function without needing to change things manually. One of them is that we have to revert to the old docker-worker version, as the node bundled with docker-worker is too new for Ubuntu 18 (a GLIBC version is required that is 0.01 versions too new for 18.04) Note: I re-required review but that seems to have removed everyone other than Pete from the review queue.

MasterWayZ commented 1 year ago

pmoore and I talked in Zoom. Made some changes and awaiting feedback for Monday from mboris.

MasterWayZ commented 1 year ago

Changes LGTM! Just one small outstanding ask from Pete #104 (comment)

Oh, and please rebase with what's on main.

This is old code that was removed with one of your patches. I didn't come up with this, I just reverted that part because I know that is has always worked well for us in GCP.

Will rebase off of main.