Open pdehaan opened 2 years ago
Drive by review, but looks like your current ESLint config might only be linting .js and .cjs files and none of your .ts files.
DEBUG=eslint:cli-engine npx eslint . eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/.eslintrc.js +0ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/babel.config.cjs +22ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/public/options.js +17ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/rollup.config.js +16ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/tailwind.config.js +136ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/web-ext-config.dev.js +4ms eslint:cli-engine Lint /Volumes/Dev/github/mozilla/facebook-pixel-hunt/web-ext-config.js +2ms eslint:cli-engine Linting complete in: 275ms +2ms
versus
git ls-files | grep "\.ts$" src/background-loader.ts src/background.ts src/main.content.ts src/pixelHuntStudy.ts tests/integration/study.test.ts tests/integration/utils.ts
tree src/ src/ ├── background-loader.ts ├── background.ts ├── generated/ │ ├── facebookPixel.ts │ ├── pings.ts │ ├── rally.ts │ └── userJourney.ts ├── main.content.ts └── pixelHuntStudy.ts 1 directory, 8 files
tree -I node_modules --gitignore
Drive by review, but looks like your current ESLint config might only be linting .js and .cjs files and none of your .ts files.
versus
```sh tree -I node_modules --gitignore . ├── CODE_OF_CONDUCT.md ├── LICENSE ├── README.md ├── RELEASE_PROCESS.md ├── STUDY_QA.md ├── babel.config.cjs ├── docs │ └── metrics.md ├── manifest.dev.json ├── manifest.prod.json ├── metrics.yaml ├── package-lock.json ├── package.json ├── pings.yaml ├── public │ ├── options.html │ └── options.js ├── rollup.config.js ├── screenshots │ └── README.md ├── scripts │ └── integration-test.sh ├── src │ ├── background-loader.ts │ ├── background.ts │ ├── generated │ │ ├── facebookPixel.ts │ │ ├── pings.ts │ │ ├── rally.ts │ │ └── userJourney.ts │ ├── main.content.ts │ └── pixelHuntStudy.ts ├── tailwind.config.js ├── tests │ └── integration │ ├── study.test.ts │ ├── utils.ts │ └── webarchive │ ├── create-archive.sh │ └── localhost │ ├── img.html │ ├── index.html │ ├── js.html │ └── tr ├── tsconfig.json ├── web-ext-config.dev.js └── web-ext-config.js 10 directories, 37 files ```tree -I node_modules --gitignore