search

mozilla-rally / facebook-pixel-hunt

Mozilla Public License 2.0
6 stars 4 forks source link

[Bug] pixel hunt chrome addon does not send attention data when under 1ms #180

Closed betling closed 2 years ago

betling commented 2 years ago

two attention-related metrics are currently not making it into the private analysis environment. 'metrics.quantity.user_journey_attention_and_audio_duration' and 'metrics.quantity.user_journey_max_relative_scroll_depth'. rob is investigation and believes he's found the issue but need to do some test. This happens on both chrome and firefox.

rhelmer commented 2 years ago

two attention-related metrics are currently not making it into the private analysis environment. 'metrics.quantity.user_journey_attention_and_audio_duration' and 'metrics.quantity.user_journey_max_relative_scroll_depth'. rob is investigation and believes he's found the issue but need to do some test. This happens on both chrome and firefox.

@betling thanks! Do we ever see the data? It should only be coming in undefined if the values are below 1.

rhelmer commented 2 years ago

OK this is from us working around Glean not liking us sending sub-ms times, we could round this to the nearest ms instead of just sending undefined though, this would make analysis easier.

marniepw commented 2 years ago

Can we close this since the Pixel Hunt study ended? Or is this bug found with other studies/the attention stream?

rhelmer commented 2 years ago

Can we close this since the Pixel Hunt study ended? Or is this bug found with other studies/the attention stream?

It looks like we fixed this in Attention Stream by setting Math.floor on these values from WebScience pageData before passing them to Glean.