Enrollment flow: Proposal for study add-ons having install prompt suppressed (CA-P3) - Githubissues

mozilla-rally / rally-core-addon

Mozilla Public License 2.0

9 stars 13 forks source link

Enrollment flow: Proposal for study add-ons having install prompt suppressed (CA-P3) #162

Open marniepw opened 4 years ago

marniepw commented 4 years ago

Proposal needed for study add-ons having install prompt suppressed.

marniepw commented 4 years ago

Can we add code to core add on that let's us install certain add-ons w/out prompts.

rhelmer commented 3 years ago

I'm going to rename this proposal https://docs.google.com/document/d/1eS5MdZliEC0jANVUnRnAqTWiCviItsxHTNyF_brADgw/edit?disco=AAAAIwv9QB0&usp_dm=true&ts=5fabd130 since it's basically about this issue.

marniepw commented 3 years ago

Proposal needs to be reviewed by Addons admin; they need to buy in to the proposed path forward.

rhelmer commented 3 years ago

There are two parts here:

study add-ons should get a recommendation "badge" by AMO to prevent unknown site warning
Ion core add-on should be able to suppress standard install prompt (CA-P2)

marniepw commented 3 years ago

Need special permissions for this; harder ticket. Needs review with Addons team. Likely will stretch into following sprint.

rhelmer commented 3 years ago

To separate this out a bit:

CA-P2: this will go away if we get an AMO badge ("By Mozilla", "Recommended", etc.)
CA-P3: there is no standard way to suppress this, we'd need privileged code either in Firefox or in the Ion Core extension.

rhelmer commented 3 years ago

To separate this out a bit:

* CA-P2: this will go away if we get an AMO badge ("By Mozilla", "Recommended", etc.)

* CA-P3: there is no standard way to suppress this, we'd need privileged code either in Firefox or in the Ion Core extension.

Actually I just went ahead and split CA-P2 out to a separate issue: https://github.com/mozilla-ion/ion-core-addon/issues/246

rhelmer commented 3 years ago

OK, I think we can cover this in the Reducing Friction in Ion Enrollment Flow proposal, there's a bullet point for this now but it needs to be fleshed out further.

I've prototyped this a bit and calling AddonManager.getInstallForURL() from a privileged API bundled in the XPI works, it gives us back an install object which we can use to trigger the download+install and also get progress (if we want to show something in the UI while it downloads).

We chatted with @wagnerand and @kewisch this morning, and skipping this prompt sounded reasonable to everyone since the user has already jumped through multiple consent hoops. So I think getting into the details in the proposal is what's needed here at this point.

Dexterp37 commented 3 years ago

We chatted with @wagnerand and @kewisch this morning, and skipping this prompt sounded reasonable to everyone since the user has already jumped through multiple consent hoops. So I think getting into the details in the proposal is what's needed here at this point.

Note that @wagnerand and @kewisch did not commit to anything. There were some concern about surfacing the information that we usually display in the install prompt in our concern notice and making sure to keep them in sync. Can we have one section in your proposal specifically about this, @rhelmer ?

marniepw commented 3 years ago

Next steps: product decision on path forward and how we'd like to engage w/AMO re: work required.