search

mozilla-rally / rally-core-addon

Mozilla Public License 2.0
9 stars 13 forks source link

"successfully joined study" banner appears when the user declines to install the study extension #634

Open jonathanmayer opened 3 years ago

jonathanmayer commented 3 years ago

On the Current Studies page, if you click Join Study, click Accept & Enroll, then click Cancel on the study extension install request, the "successfully joined study" banner still appears. The issue appears to be at:

https://github.com/mozilla-rally/rally-core-addon/blob/2a752df6cd771dce0811115625413241e6f33395/src/routes/Main.svelte#L29

The notification should probably be triggered by completing rather than starting study extension installation:

https://github.com/mozilla-rally/rally-core-addon/blob/81a6ee4b3a58cffb303a8f8f33b231eef00710ae/core-addon/Core.js#L146

rhelmer commented 3 years ago

Hm, I could swear we had an issue filed for this already... @hamilton do you know?