Should we return after sending COMPLETE_SIGNUP if user is not authenticated?

mozilla-rally / rally-sdk

This is the Rally partner support library, `rally.js`, used to manage the lifecycle of Rally studies.

0 stars 4 forks source link

Should we return after sending COMPLETE_SIGNUP if user is not authenticated? #26

Closed thomik-corp closed 2 years ago

thomik-corp commented 2 years ago

Not sure if we should continue sending web check response

https://github.com/mozilla-rally/rally-sdk/blob/a06c3768dfec42a3bc0e4aa57d7d376566d05cd6/src/rally.ts#L298-L307

rhelmer commented 2 years ago

Hm, well the response is to let the site know that the extension is present, but I see what you mean. If we expect the site to be able to do something useful with that information we should keep it. I think I did it this way just so there's a consistent call/response pattern.

thomik-corp commented 2 years ago

Resolving since we must always send a web check response with study id to indicate presence of an extension.