search

mozilla-rally / rally-sdk

This is the Rally partner support library, `rally.js`, used to manage the lifecycle of Rally studies.
0 stars 4 forks source link

Remove core add-on support, add tests and release process #7

Closed rhelmer closed 3 years ago

rhelmer commented 3 years ago

This PR removes support for the core add-on, including bringing over tests ~and Glean for enrollment pings (since we can't rely on the core add-on to do this for us anymore).~

I'm assuming that any callers in the immediate future will be using rally.js still, so the tests are all written against this, and this is what we'll publish to npm. This is a really major change so I'm bumping the version number to 1.0.0, and although it's possible we'll provide some kind of smooth upgrade path, I'm not worrying about that in this PR.

rhelmer commented 3 years ago

Hm, so I had ported over the study and platform enrollment/unenrollment/deletion glean metrics... but now that I think about it, I'm not really sure the SDK needs these at all. Pings for these can be send on the server side since they will be tied to identity, the SDK just needs to detect this and prevent studies from starting up.