547 update storybook - Githubissues

mozilla-rally / rally-web-platform

Mozilla Public License 2.0

5 stars 5 forks source link

547 update storybook #561

Closed Carla-Moz closed 2 years ago

Carla-Moz commented 2 years ago

Role of Reviewer: check whether the new settings components in storybook meet the initial request to have design review front end work.
Can merge after single review.
Urgency is normal

Description: this PR adds the settings component to storybook. Run the command npm run storybook, go to localhost: 6006, use the sidebar to navigate to the Settings components.

You can access it through here too:Rally storybook

aaga commented 2 years ago

@Carla-Moz in the spirit of our new PR norms, do you mind commenting with the expectations of review:

the role of each reviewer
whether it’s ok to merge after a single review or not (not relevant to this PR since it's just me but putting here for info)
urgency if there is any

don't worry I'm already well into reviewing this! I'm just prompting so we can build habits.

Carla-Moz commented 2 years ago

@aaga, no prob! Thanks for the reminder. Also, once this goes through, I can have your updated styles up fortweak-delete-accountbranch.