search

mozilla-rally / rally

A monorepo for Rally project containing Rally SDK, Rally Web Platform and Extensions.
Mozilla Public License 2.0
7 stars 6 forks source link

[Bug] Rally extension attempts to onboard at random times with MV3 #358

Open rhelmer opened 2 years ago

rhelmer commented 2 years ago

Describe the bug

To Reproduce

  1. Create a new Chrome profile
  2. install the Rally Extension in Chrome
  3. do not sign into site when onboarding is attempted

In MV2 the persistent background page would open a tab to https://members.rally.mozilla.org/studies in an attempt to onboard users (users need to be logged into the site so the extension can get its login token) on every browser start. With MV3 however the background page is replaced with a service worker, that can wake up at random times and trigger onboarding

Expected behavior Onboarding attempts happen infrequently enough not to bother users, at a predictable time or after browser startup.

Screenshots If applicable

Browser / OS:

Additional context

rhelmer commented 1 year ago

We haven't had many complaints about this, but we just received one about the latest Rally extension triggering on-boarding at random times on Chrome, even though it's logged in and activated. Asking for more details on that, but sign-in can fail for many reasons (most of them temporary), so we should make this onboarding attempt less aggressive and more intentional anyway.