mozilla-rally / rally

A monorepo for Rally project containing Rally SDK, Rally Web Platform and Extensions.
Mozilla Public License 2.0
7 stars 6 forks source link

Verify email toast and extension first privacy modal #382

Closed Carla-Moz closed 2 years ago

Carla-Moz commented 2 years ago

This PR completes the following major tasks:

  1. It adds privacy modal to the products page for the extension first onboarding flow
  2. Adds the verify email, privacy policy, and add extension toasts
  3. Adds the check your email modal

@tangcasey, I changed the position of the toast because I don't think they should block the user dropdown icon.

Screen Shot 2022-10-11 at 10 57 40 PM Screen Shot 2022-10-10 at 7 29 37 PM Screen Shot 2022-10-11 at 4 40 03 PM

@aaga, you can where I put the product toasts and alerts in rally/web-platform/website/src/components/pages/studies/ProductAlerts.tsx and can update Strings in rally/web-platform/website/src/resources/Strings.tsx

closes #374 closes #375 closes #378 closes #377

netlify[bot] commented 2 years ago

Deploy Preview for rally-prod ready!

Name Link
Latest commit c1dadcfe0db9db9ed7602ffc3561ef5ce5d20b0b
Latest deploy log https://app.netlify.com/sites/rally-prod/deploys/634714d05a5f920008ca3df1
Deploy Preview https://deploy-preview-382--rally-prod.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for rally-staging ready!

Name Link
Latest commit c1dadcfe0db9db9ed7602ffc3561ef5ce5d20b0b
Latest deploy log https://app.netlify.com/sites/rally-staging/deploys/634714d00640bc00087abb98
Deploy Preview https://deploy-preview-382--rally-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thomik-corp commented 2 years ago

We already have exclaimation icon in public/img in warning.svg.

thomik-corp commented 2 years ago

We do not require any new images since we have

jepstein commented 2 years ago

I'm not seeing the email verification modal when signing up with a new email account.

Carla-Moz commented 2 years ago

I'm not seeing the email verification modal when signing up with a new email account.

Could you please post a picture of where you're not seeing this?

Carla-Moz commented 2 years ago

I'm not seeing the email verification modal when signing up with a new email account.

Could you please post a picture of where you're not seeing this?

jepstein commented 2 years ago

I get the toast, but the modal doesn't appear.

https://user-images.githubusercontent.com/444356/195375849-d3d931d9-8057-429f-82f1-d7432d2b714d.mov

Carla-Moz commented 2 years ago

I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov

@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?

jepstein commented 2 years ago

I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov

@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?

Aha! Didn't realize that's how it worked. Sorry for the misdirection. It's working just as expected.

Carla-Moz commented 2 years ago

I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov

@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?

Aha! Didn't realize that's how it worked. Sorry for the misdirection. It's working just as expected.

YAY! Thanks for testing

Carla-Moz commented 2 years ago

Looks good. We can remove the icon-checkmark.svg and I made a simple spelling suggestion. Rest looks good to me.

Thank you! I'll add the tests when I refactor the Product Toast file.