Closed Carla-Moz closed 2 years ago
Name | Link |
---|---|
Latest commit | c1dadcfe0db9db9ed7602ffc3561ef5ce5d20b0b |
Latest deploy log | https://app.netlify.com/sites/rally-prod/deploys/634714d05a5f920008ca3df1 |
Deploy Preview | https://deploy-preview-382--rally-prod.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Name | Link |
---|---|
Latest commit | c1dadcfe0db9db9ed7602ffc3561ef5ce5d20b0b |
Latest deploy log | https://app.netlify.com/sites/rally-staging/deploys/634714d00640bc00087abb98 |
Deploy Preview | https://deploy-preview-382--rally-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
We already have exclaimation icon in public/img in warning.svg.
We do not require any new images since we have
img/check-circle.svg
img/error.svg
img/your-contact-data.png
I'm not seeing the email verification modal when signing up with a new email account.
I'm not seeing the email verification modal when signing up with a new email account.
Could you please post a picture of where you're not seeing this?
I'm not seeing the email verification modal when signing up with a new email account.
Could you please post a picture of where you're not seeing this?
I get the toast, but the modal doesn't appear.
https://user-images.githubusercontent.com/444356/195375849-d3d931d9-8057-429f-82f1-d7432d2b714d.mov
I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov
@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?
I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov
@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?
Aha! Didn't realize that's how it worked. Sorry for the misdirection. It's working just as expected.
I get the toast, but the modal doesn't appear. Screen.Recording.2022-10-12.at.10.49.34.AM.mov
@jepstein The "check your email" modal is supposed to appear after you hit "Resend" on the "verify your email" toast. Could you please try pressing the "Resend" button on the toast?
Aha! Didn't realize that's how it worked. Sorry for the misdirection. It's working just as expected.
YAY! Thanks for testing
Looks good. We can remove the icon-checkmark.svg and I made a simple spelling suggestion. Rest looks good to me.
Thank you! I'll add the tests when I refactor the Product Toast file.
This PR completes the following major tasks:
@tangcasey, I changed the position of the toast because I don't think they should block the user dropdown icon.
@aaga, you can where I put the product toasts and alerts in
rally/web-platform/website/src/components/pages/studies/ProductAlerts.tsx
and can update Strings inrally/web-platform/website/src/resources/Strings.tsx
closes #374 closes #375 closes #378 closes #377