search

mozilla-releng / balrog

Mozilla's Update Server
http://mozilla-balrog.readthedocs.io/en/latest/index.html
Mozilla Public License 2.0
100 stars 148 forks source link

/releases/xxxxxxx/v2 should be able to create a new release #2994

Open jcristau opened 1 year ago

jcristau commented 1 year ago

I'm not sure if I'm doing something wrong here, but when trying to create a release I go to e.g. https://balrog.services.mozilla.com/releases/Widevine-4.10.2710.0/v2, then paste or upload the blob, but the form won't let me enter the product name, which means form submission fails. Going into devtools to replay the request having added the product to the request body does work.

ademolaomosanya commented 1 year ago

i'm an outreachy applicant and i would like to work on this issue kindly asign me

Raven49 commented 1 year ago

Kindly assign this task to me

bhearsum commented 1 year ago

@jcristau - can you still reproduce this? I wasn't able to with the latest main.

Is it possible you were on an Update page instead of a Create page? If so, not being able to edit the name is expected.

jcristau commented 1 year ago

It's possible I was on an Update page, I don't know the difference :)

bhearsum commented 1 year ago

It's possible I was on an Update page, I don't know the difference :)

The main indication is the page title. The route and UI are otherwise identical.

jcristau commented 1 year ago

Thanks, OK, so I guess the bug from my point of view is that /releases/doesnotexist/v2 should give me the "new release" page and pre-fill the name, instead of giving me an "update a release that does not exist and that you can't actually update" page. Does that sound reasonable?

bhearsum commented 1 year ago

Thanks, OK, so I guess the bug from my point of view is that /releases/doesnotexist/v2 should give me the "new release" page and pre-fill the name, instead of giving me an "update a release that does not exist and that you can't actually update" page. Does that sound reasonable?

Yeah, I think that makes sense. I guess the thing that surprises me is how you're getting to a page like that though? I guess it's a manually entered URL, as I don't see how you could get there via the UI.

jcristau commented 1 year ago

Correct. Partly because usually the new release I want to create is a variation on an existing one, but there's no "duplicate" button for releases like there is for rules. Partly because the "new release" button is on the /releases page which itself takes forever to load.

bhearsum commented 1 year ago

I've updated the summary to match what we've discussed. It looks like the fix here is going to involve a couple of things: