search

mozilla-releng / balrog

Mozilla's Update Server
http://mozilla-balrog.readthedocs.io/en/latest/index.html
Mozilla Public License 2.0
100 stars 148 forks source link

partial match filter on releases #2997

Closed nazarenegena closed 1 year ago

nazarenegena commented 1 year ago

Fixes issue #1146

Allows partial filtering of releases when a search value such as "fire 60" is entered.

gabrielBusta commented 1 year ago

It would be helpful for users if the matching parts of their search is highlighted in the results. This would give visual feedback about what part of their query matched.

nazarenegena commented 1 year ago

Thank you for the feedback. should I go ahead and implement the highlighting and the performance check?

gabrielBusta commented 1 year ago

Regarding the highlighting, we have two options: we can open an issue for further follow-up and merge this pull request as it is, or you can address it directly here. The choice is yours. As for performance, what specific checks were you considering? It would be beneficial to gauge the code's performance on several thousand releases before deploying to production. However, if testing proves too cumbersome, we might consider deploying it to production directly and observing its performance there. If the speed is insufficient, we can always revert. We shouldn't prematurely optimize the code without identifying an issue. Should we encounter problems, there are various solutions to explore. For instance, we could think about debouncing the search. This approach would delay the search function execution until the user pauses typing for a brief moment, like 300ms, rather than executing on every keypress.

nazarenegena commented 1 year ago

Yes, you can go ahead and merge this request create a new issue for the highlights and assign it to me.

gabrielBusta commented 1 year ago

OK I created #3007 as a follow-up to this issue.