don't prompt for signoff with roles that aren't relevant

[CREDO23]

This PR resolve the #1145 issue

Changes made:

• Retreive required roles:

          useEffect(() => {
              const roles =
                requiredSignoffs.data &&
                requiredSignoffs.data.data.required_signoffs.map(el => {
                  return el.role;
                });
  
              setRequiredRoles(roles);
          }, []);

• Disable roles that are not required

      const signoffDialogBody = (
          <FormControl component="fieldset">
            <RadioGroup
              aria-label="Role"
              name="role"
              value={signoffRole}
              onChange={handleSignoffRoleChange}>
              {roles.map(r => {
                return (
                  <FormControlLabel
                    key={r}
                    value={r}
                    label={r}
                    control={<Radio />}
                    disabled={!(requiredRoles && requiredRoles.includes(r))}
                  />
                );
              })}
            </RadioGroup>
          </FormControl>
      );

• If the user has only one role in the required role list, signoff directly:

        const handleSignoff = async rule => {
          const userRequiredRoles = requiredRoles.filter(r => roles.includes(r));
  
          if (userRequiredRoles.length === 1) {
            const { error, result } = await doSignoff(userRequiredRoles[0], rule);
  
            if (!error) {
              updateSignoffs(result);
            }
          } else {
            setDialogState({
              ...dialogState,
              open: true,
              title: 'Signoff as…',
              confirmText: 'Sign off',
              item: rule,
              mode: 'signoff',
              handleComplete: handleSignoffDialogComplete,
              handleSubmit: handleSignoffDialogSubmit,
            });
          }
  };

[gabrielBusta]

Thanks for your contribution @CREDO23 I will test it out soon.

[CREDO23]

@gabrielBusta, have you tested it ?

[CREDO23]

@gabrielBusta, @bhearsum now:

• If a user has releng, relman, tb-releng and required roles are 1 relman, 1 releng then show a popup so that the user can choose a role to sign with. Here, only releng or relman are allowed
• If a user has relman and required roles are 1 relman, 1 releng then signoff directly upon update. No need to show a popup
• If a user has tb-releng and required roles are 1 relman, 1 releng then disable the signoff button.

Here is a demo here

[bhearsum]

@gabrielBusta - it looks like this is ready for another look?

[gabrielBusta]

Thanks @CREDO23!

Works for me on the local instance.

[AMUZY]

I actually just tested this and I like it . Great work @CREDO23 .