mozilla-releng / balrog

Mozilla's Update Server
http://mozilla-balrog.readthedocs.io/en/latest/index.html
Mozilla Public License 2.0
100 stars 148 forks source link

Show required signoffs when updating rules #3025

Closed michellemounde closed 1 year ago

michellemounde commented 1 year ago

Fixes #1147

  1. Fetch the required signoffs and check them against the rule to find matching ones
  2. Create an element to display matching signoffs

No signoffs required - greyed out Screenshot from 2023-10-20 15-22-37

Signoffs from one role required Screenshot from 2023-10-20 15-22-57

Signoffs from two roles required Screenshot from 2023-10-20 15-23-22

AMUZY commented 1 year ago

looks exactly like my fix. lol

michellemounde commented 1 year ago

@AMUZY I don't know what your code looks like but I wrote my own code.

AMUZY commented 1 year ago

It's cool though. just saw your code, looks cool too. Different approaches to solving one issue

bhearsum commented 1 year ago

@michellemounde - did you push the right thing here? It doesn't look like this branch has the changes you want anymore...if you want a hand getting back to a good state feel free to ping me on Matrix.

michellemounde commented 1 year ago

@michellemounde - did you push the right thing here? It doesn't look like this branch has the changes you want anymore...if you want a hand getting back to a good state feel free to ping me on Matrix.

Thanks for the help.

michellemounde commented 1 year ago

@bhearsum I have removed the conditionals so that the classes.signoffs is always present

AMUZY commented 1 year ago

Nice work @michellemounde