search

mozilla-releng / balrog

Mozilla's Update Server
http://mozilla-balrog.readthedocs.io/en/latest/index.html
Mozilla Public License 2.0
100 stars 148 forks source link

Prevent scheduling a new rule with a duplicate alias #3029

Closed michellemounde closed 1 year ago

michellemounde commented 1 year ago

Fixes #2942

  1. Add duplicate alias check at API level to RuleScheduledChangesView

Before insert: Screenshot from 2023-10-23 14-45-45

On insert: Screenshot from 2023-10-23 14-45-54

michellemounde commented 1 year ago

Ok @bhearsum will work on the changes. I have a question regarding the failing check. I've looked at the details but I am not sure how to fix the issue so that the check passes.

bhearsum commented 1 year ago

Ok @bhearsum will work on the changes. I have a question regarding the failing check. I've looked at the details but I am not sure how to fix the issue so that the check passes.

That error looks unrelated to your change. It will probably fix itself the next time you push - don't worry about it.

bhearsum commented 1 year ago

This ended up getting fixed in #3010 first.