Bug 1882147 - Support legacy keys for signing json responses

mozilla-releng / balrog

Mozilla's Update Server

http://mozilla-balrog.readthedocs.io/en/latest/index.html

Mozilla Public License 2.0

99 stars 149 forks source link

Bug 1882147 - Support legacy keys for signing json responses #3110

Closed hneiva closed 4 months ago

hneiva commented 4 months ago

I felt like semver was the right option for calculating version numbers, but I'm not 100% it will cover all our cases. I'm happy to re-implement with a different method if it makes more sense.

JohanLorenzo commented 4 months ago

I think using semver makes sense. Not blocking: I'd recommend moving the semver call to https://github.com/mozilla-releng/mozilla-version/. This way, mozilla-version remains the one source of truth for parsing versions of Mozilla's products. That'll prevent any duplication next time we have to deal with a Mozilla VPN version number.

hneiva commented 4 months ago

Cloudops-infra portion is merged in https://github.com/mozilla-services/cloudops-infra/pull/5561