py3 async-ify balrogscript

[escapewindow]

12:18 <aki> do we have lib/python/balrog/ py3 replacements yet?
12:19 <bhearsum> not async ones, but https://github.com/mozilla/balrog/tree/master/client is py3 compatible
12:19 <bhearsum> thanks to sfraser 
12:19 <aki> ooh
12:20 <aki> so i could import balrogclient
12:20 <bhearsum> yup
12:24 <aki> looks like it's not backwards compatible though
12:24 <bhearsum> with 2.7?
12:25 <aki> if we're using NightlySubmitterV4, ReleaseSubmitterV4, is there a doc or something to figure out how to do it with balrogclient.api, or do i just look at code
12:25 <bhearsum> there's no doc that i'm aware of
12:27 <sfraser> I think those classes are in cli.py rather than the api.py
12:27 <aki> yes, i was just figuring that out :)
12:27 <bhearsum> i think balrogclient/api.py interfaces are the same as the old ones though, if that's what you were asking?
12:28 <aki> looks like it's not a drop in replacement for lib/python/balrog if i need submitter.cli, but it's a good base
12:28 <bhearsum> right, it's a replacement for api.py, not cli.py
12:28 <bhearsum> sorry, i didn't recognize that were you asking about both!
12:28 <aki> do we want to keep cli.py, or should i dup those functions in balrogscript?
12:29 <bhearsum> don't dupe them in there, not yet anyways
12:29 <aki> so keep using tools for now?
12:29 <bhearsum> yeah
12:29 <aki> ok
12:29 <bhearsum> i want to merge them into the blob classes around the time https://bugzilla.mozilla.org/show_bug.cgi?id=1312868 gets fixed
12:29 <aki> easy enough to wait
12:30 <aki> ty
12:30 <bhearsum> np, sorry it's not exactly what you needed
12:30 <aki> no worries
12:31 <aki> i was just asking just in case :)
12:31 <aki> i expected to need tools for the near term

[MihaiTabara]

This is not blocking Tier-1 and requires cli.py migration to py3 under tools which is something we don't know when we'll address in the future. Putting this on hold for now.

[escapewindow]

Related: bug 1404484 - update python on balrog scriptworkers to avoid ssl warnings

[JohanLorenzo]

Whenever balrogscript is being py3'd, it can rely on scriptworker to:

• deal with the event loop
• initialize the context and the config
• fetch and initialize the task config
• verify task schema.

Work was done in bug1445593

[tomprince]

Now that code has moved out of built-tools, this should be simpler. I think the major bit of code that needs to be ported is [https://github.com/mozilla-releng/balrogscript/tree/master/balrogscript/submitter].

It probably makes sense to simplify that code as a first step. balrogscript.submitter.cli has a bunch of inheritance, but none of the mixins are used by more than one leaf class, so they can all be merged so there is no inheritance. In addition, all the uses of the classes are to create an instance, and call exactly one method on it; I think we could simplify things to just call free functions instead.