search

mozilla-releng / beetmoverscript

An implementation of scriptworker for moving TC artifacts to all release-related buckets.
1 stars 19 forks source link

We should be testing the real templates, not fake templates within tests. #116

Closed MihaiTabara closed 5 years ago

MihaiTabara commented 6 years ago

https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/test/fake_config.json#L16 should be pointing at real templates to have a minimum coverage there as well.

MihaiTabara commented 6 years ago

I am hoping we do this in-tree once we move artifacts there, with @lisajguo's work.

MihaiTabara commented 6 years ago

We're tracking this work in 1462393. Once we have templates in-tree, I'm hoping for tests there as well.

MihaiTabara commented 6 years ago

This will probably be retired once we have declarative artifacts. With the manifest in-tree we'll be able to implement testing there.

lundjordan commented 5 years ago

This will probably be retired once we have declarative artifacts. With the manifest in-tree we'll be able to implement testing there.

@MihaiTabara - does this issue still apply given declarative artifacts?

MihaiTabara commented 5 years ago

We'll add tests in-tree at some point to check the routes. We can safely close this. Thanks for uncovering this.