mozilla-releng / beetmoverscript

An implementation of scriptworker for moving TC artifacts to all release-related buckets.
1 stars 19 forks source link

declarative artifacts design collab #167

Closed lisajguo closed 6 years ago

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 598


Totals Coverage Status
Change from base Build 596: 0.0%
Covered Lines: 479
Relevant Lines: 485

💛 - Coveralls
escapewindow commented 6 years ago

We came up with 3 new concerns:

@MihaiTabara and I brainstormed expanding all paths in the transforms, and then giving beetmoverscript a list of non-templatized pretty paths per artifact, e.g.

    "artifactMap": {
      "<task_id>" : {
        "public/build/target.tar.bz2": {
            "pretty_paths": [
               "pub/firefox/nightly/2018/07/05/linux/firefox-63.0a1.tar.bz2",
            ]
          }
       }
    }

If we don't foresee needing to add any more info, we could make it

"public/build/target.tar.bz2": [pretty_path1, pretty_path2]

rather than a dictionary. However, a dictionary allows for adding more info in the future.

lisajguo commented 6 years ago

Mihai and I just talked about partials:

we should name partials in the manifest something like "target.partial.mar" as a generic way to identify them in the manifest without logic. In the simple name, we can specify: target-{{ version }}-partial.mar

escapewindow commented 6 years ago

we should name partials in the manifest something like "target.partial.mar" as a generic way to identify them in the manifest without logic. In the simple name, we can specify: target-{{ version }}-partial.mar

I think {{ version }} refers to the current version. In the partial artifact, the version is the previous version. We may want to use previous_version or something. We currently have multiples of these per partial task, e.g. https://tools.taskcluster.net/groups/Ei6VY3A1S_6b8_eT7wvbAA/tasks/A7CfEsUfRPiFZdnsosCf5Q/runs/0/artifacts has public/build/af/target-62.0b6.partial.mar, public/build/af/target-62.0b7.partial.mar, and public/build/af/target-62.0b8.partial.mar