search

mozilla-releng / beetmoverscript

An implementation of scriptworker for moving TC artifacts to all release-related buckets.
1 stars 19 forks source link

buildhub.json's download.url is 404 #195

Closed rail closed 5 years ago

rail commented 5 years ago

Looking at this buildhub.json I see:

"download": {
        "date": "2018-12-10T11:46:18.893852+00:00",
        "mimetype": "application/octet-stream",
        "size": 69585249,
        "url": "https://archive.mozilla.org/https%3A/archive.mozilla.org/2018/12/2018-12-10-09-55-04-mozilla-central/firefox-65.0a1.en-US.linux-x86_64.tar.bz2"
    },

Looks like something went wrong with mangling the URL.

MihaiTabara commented 5 years ago

Oups, thanks for raising this. Might be a fallout from declarative artifacts PR. I'll have a look.

rail commented 5 years ago

I can review the fix ;)

rail commented 5 years ago

it's also interesting that it misses pub/firefox/nightly in the path.

rail commented 5 years ago

Something tells me that we should revert just one line here. We definitely need the s3_bucket_path piece and shouldn't add url_prefix twice.

Maybe @srfraser has better context here.

srfraser commented 5 years ago

We need s3_bucket_path if we're not using the artifact map, but we don't need it if we're not. Maybe it's a case of moving line 204 above line 198, and having url = urllib.parse.quote(urllib.parse.urljoin(manifest["s3_bucket_path"], dest[0])) in the else block

rail commented 5 years ago

Something like this? Sorry, blindly trying to guess. :)

srfraser commented 5 years ago

Yes, that should be fine.