Fix buildhub.json download.url, take 2

mozilla-releng / beetmoverscript

An implementation of scriptworker for moving TC artifacts to all release-related buckets.

1 stars 19 forks source link

Fix buildhub.json download.url, take 2 #200

Closed rail closed 5 years ago

rail commented 5 years ago

Unfortunately the previous fix didn't work properly. Instead of generating the full URL, it generates only the part after the hostname. Adding s3_bucket_path should fix the issue.

This should also fix the issue, where we try to quote after generating the full URL when artifact_map is specified, so we don't get the https%3A// prefix.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 781

5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.474%

Totals
Change from base Build 778:	0.0%
Covered Lines:	756
Relevant Lines:	760

💛 - Coveralls

MihaiTabara commented 5 years ago

@rail let me know if you want me to roll this out to production.

rail commented 5 years ago

@rail let me know if you want me to roll this out to production.

I'd appreciate this!

MihaiTabara commented 5 years ago

Rolled-out to production via https://github.com/mozilla-releng/build-puppet/pull/336