Bugfix: geckoview missing actual submission to S3.

mozilla-releng / beetmoverscript

An implementation of scriptworker for moving TC artifacts to all release-related buckets.

1 stars 19 forks source link

Bugfix: geckoview missing actual submission to S3. #232

Closed MihaiTabara closed 5 years ago

MihaiTabara commented 5 years ago

Tested locally, works smoothly.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 921

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 98.745%

Totals
Change from base Build 918:	0.002%
Covered Lines:	787
Relevant Lines:	797

💛 - Coveralls

MihaiTabara commented 5 years ago

LGTM. As a follow up, let's add a test that makes sure move beets is called. That will help us in the upcoming code deletion (once we get rid of target.maven.zip)

Yeah, good point. I'm adding a todo to myself, but for now I want to roll this to unblock folks there.