Use functions exposed by scriptwoker.client

MihaiTabara commented 6 years ago

@JohanLorenzo Sorry to have stolen this but I wanted to give this a try since I had already bouncerscript context and I was working on adding more tests for the configurations. This sort-of was incoming anyway and would've blocked my work there.

A word on load_json, I moved it from main scripts under tests since it's being used there, but I'll redo the tests to use integration tests instead of local files. You've set some good example in shiptitscript repo which I think is way better than what I currently have now. I filed https://github.com/mozilla-releng/bouncerscript/issues/14 to track this later on.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 50

14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 48:	0.0%
Covered Lines:	134
Relevant Lines:	134

💛 - Coveralls

MihaiTabara commented 6 years ago

Merging this to master and start testing on staging. Any comments added here will be picked up in my upcoming PR for bug 1445684.

mozilla-releng / bouncerscript

Use functions exposed by scriptwoker.client #15

Pull Request Test Coverage Report for Build 50

💛 - Coveralls