Add preflight checks for bouncer aliases job.

mozilla-releng / bouncerscript

1 stars 9 forks source link

Add preflight checks for bouncer aliases job. #16

Closed MihaiTabara closed 6 years ago

MihaiTabara commented 6 years ago

add check for bouncer aliases job (via puppet config)
some simplifying in the tests

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 55

17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 51:	0.0%
Covered Lines:	149
Relevant Lines:	149

💛 - Coveralls

MihaiTabara commented 6 years ago

Thanks for fast turnaround and comments. Pushed a fix to raise that TaskVerificationError. Will roll-out this in the staging releases and will follow-up in a bit with the puppet patch.

MihaiTabara commented 6 years ago

@JohanLorenzo ready for a follow-up review after addressing your comments.

MihaiTabara commented 6 years ago

Bouncer-submission + bouncer aliases work as expected in staging. If any un-expected issues come up, we can just pin to previous version. Rolling-this out to production.

MihaiTabara commented 6 years ago

Thank you both @escapewindow @JohanLorenzo for comments!