mozilla-releng / bouncerscript

1 stars 9 forks source link

Add checks to validate the bouncer aliases values after API calls. #31

Closed MihaiTabara closed 6 years ago

MihaiTabara commented 6 years ago

In bug 1470226 we're adding some suplimentary checks to make sure the updates we're performing against bouncer are correctly reflected on bouncer DB side. This one is specifically for the bouncer aliases job.

This PR takes care of it + some other things along the way:

There is no API to call for bouncer aliases values, hence we're using the go-bouncer public interface to query for this data. Idea came here.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 95


Totals Coverage Status
Change from base Build 93: 0.0%
Covered Lines: 213
Relevant Lines: 213

💛 - Coveralls
MihaiTabara commented 6 years ago

I triggered a bunch of tasks in staging releases and they work smoothly, modulo the fact that the product checks against downloads.mozilla.org are failing, as expected. This should work smoothly in production.

https://taskcluster-artifacts.net/M0wJJHI8TpSDS4Oz_gt54Q/0/public/logs/live_backing.log https://taskcluster-artifacts.net/eTXIxnDxTTO4XAzjbrgYoQ/0/public/logs/live_backing.log

MihaiTabara commented 6 years ago

This is looking good. Am merging this to master, it'll get picked up by the next roll-out of bouncerscript.