automate nightly latest bouncer products

lisajguo commented 6 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1432656

lisajguo commented 6 years ago

Based on Mihai's task https://tools.taskcluster.net/groups/RRARPYuXT6qHChjOW7ubyw/tasks/N9YyF5s-TuCSuvCqn4HLSA/details

lisajguo commented 6 years ago

@MihaiTabara Next to-do here:

Find out exactly what get_locations_paths returns for nightly locations
Add correct regexes for firefox-nightly-ssl, firefox-nightly-latest-l10n, and firefox-nightly-latest-l10n-ssl. I don't have access to bouncer so I can't see what the links look like. I had a screenshot for firefox-nightly-latest, so that should be okay.
Add unit tests for script.bouncer_locations, utils.get_nightly_version, utils.version_bumped_path, task.check_product_names_match_nightly_locations

MihaiTabara commented 6 years ago

Status update, leftovers:

add unit tests for all the code in this PR
scopes completition in SCOPES.md
fix all TODOs leftover in the PR
add integration tests for new behavior task
test on maple
improve testing to cover all possiblities in get_locations_paths
make sure to test the platforms for all possible products (Fennec, TB, Firefox, Devedition)
move exceptions from get_locations_info. I misread that function initially
a few more other local todos, less important to track here.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 107

25 of 90 (27.78%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-21.8%) to 78.188%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
bouncerscript/utils.py	16	27	59.26%
bouncerscript/task.py	3	16	18.75%
bouncerscript/script.py	3	44	6.82%
<!--	Total:	25	90	27.78%	-->

Totals
Change from base Build 105:	-21.8%
Covered Lines:	233
Relevant Lines:	298

Pull Request Test Coverage Report for Build 122

107 of 107 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 119:	0.0%
Covered Lines:	316
Relevant Lines:	316

💛 - Coveralls

MihaiTabara commented 6 years ago

@JohanLorenzo

This is supposed to replace the existing mergeduty steps from here. This job is supposed to run along with the nightly graph twice a day and check if the version has bumped. For most of the cases, the check will be a no-op as the in-tree version will coincide with the bouncer one. But every six weeks, after mergeduty day 2 steps, we bump and tag central + respin nightlies. In that graph, that specific bouncer locations job will bump that automatically.

(CC-ing @escapewindow to keep him in the loop as he was the first to suggest this improvement)

MihaiTabara commented 6 years ago

Triggered a bunch of staging tasks to test the behavior in as many cases as I could cover in the code and things look good!

MihaiTabara commented 6 years ago

@JohanLorenzo Thanks again for thorough review! I addressed most of your comments (with 1-2 exceptions where I justified my reasoning). Can you please eye-roll this again to make sure things look good? There's also a thread/conversation/question for you here.

MihaiTabara commented 6 years ago

Re-testing things more staging bouncer-locations jobs look good on maple.

MihaiTabara commented 6 years ago

Thank you again @lisajguo for your groundwork contribution here! 👍 Took longer than expected to see this in production but here goes, just landed it! Great work, thanks again!

mozilla-releng / bouncerscript