Support .msi in bouncerscript

mozilla-releng / bouncerscript

1 stars 9 forks source link

Support .msi in bouncerscript #43

Closed Callek closed 6 years ago

Callek commented 6 years ago

This is not yet ready for review, but the patch set will support .msi for Nightly and releases

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 145

15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 144:	0.0%
Covered Lines:	328
Relevant Lines:	328

💛 - Coveralls

MihaiTabara commented 6 years ago

@Callek Out of curiosity, will you let the msi installer run as part of the nightly graph? (hence twice a day? Because if you do, you could actually keep the existing logic and change nothing else but the constants.py file.

Callek commented 6 years ago

@MihaiTabara So I think I've made all the necessary changes here, can you recommend how you would like me to test this and the queue in https://bugzilla.mozilla.org/show_bug.cgi?id=1475512 before deploying?

MihaiTabara commented 6 years ago

@Callek Easiest is to cherry pick the in-tree changeset to maple and pin bouncerscript-dev to encompass these change. Once we're confirmed things are working as expected, we can merge this and land to central. I can help with bouncerscript + bouncer parts.