search

mozilla-releng / bouncerscript

1 stars 9 forks source link

use HEAD instead of GET when checking if the product exists or not #7

Closed MihaiTabara closed 6 years ago

MihaiTabara commented 6 years ago

Callek> mtaba.ra: [defer until after deved b1 is done] -- is 2018-03-02 19:16:02,528 - bouncerscript.utils - INFO - Performing a GET request to https://bounceradmin.mozilla.com//product_show?product=Devedition-60.0b1-Partial-59.0b13 with kwargs {'timeout': 60} at the start of the bouncer sub log merely to check for a 404? if so, wouldn't a HEAD request be better? 13:12:03 [so we can avoid the html output in log, if nothing else] 13:13:01 sure, good improvement there if we want that. was GET in the old behavior so didn't improve that but sounds like a good issue

MihaiTabara commented 6 years ago

Dropping this. We need to parse the XML that bouncer returns and make sure it contains a certain number of XML tags.