search

mozilla-releng / bouncerscript

1 stars 9 forks source link

better fail when bouncer returns unknown #9

Closed MihaiTabara closed 6 years ago

MihaiTabara commented 6 years ago

In https://tools.taskcluster.net/groups/SdybP-zoSbaWp1x6FdHW1A/tasks/Y86FlD3cSxqo8HiRSvoUdQ/details we actually failed to submit but task was green. This is so wrong. We need to proper test the return status code or something. Or process the input and validate better to prevent this in the future.

MihaiTabara commented 6 years ago

Courtesy to https://github.com/mozilla-releng/bouncerscript/pull/25 we now have tests to: a) test submission entries before they are being sent to make sure they are correct b) talk to bouncer after updating stuff via API to make sure the entries correspond.

We should be covered now.