[FileHandler] Add extra functionality to FileHandler

mozilla-releng / firefox-infra-changelog

Automated tool which builds a changelog of commits happening on git and hg that could affect Firefox CI Infra.

2 stars 8 forks source link

[FileHandler] Add extra functionality to FileHandler #420

Closed danlabici closed 5 years ago

danlabici commented 5 years ago

Overview As we wish FileHandler to hold all the logic for when we need to implement a bunch of new functionality, when compared to the old FIC codebase, as listed below:

Functionality:

[x] Check that folders/files exist:
- [x] data (folder)
- [x] modules (folder)
- [x] - All module files .py <- If missing, download latest version from GitHub
- [x] plugins (folder)
[x] Check FileSize
[x] Rename filename (used for keeping .md files under 1mb
[x] Handle OS paths (Unix/NT)
[x] LOWPRIO Check that you have rights to write to a file.
[ ] LOWPRIO Ability to write to temp. files, if tool runs everything successfully move them to the proper locations.

danlabici commented 5 years ago

I have started to work on this Issue locally. Will send parts of the code for reviews as mini-PRs.

bccrisan commented 5 years ago

For the check that we have the rights to write to a file I have created two new methods is_readable() and is_writable() and added them to the FileHandler in PR https://github.com/mozilla-releng/firefox-infra-changelog/pull/426

bccrisan commented 5 years ago

I was also thinking how we can approach the ability to write to temp files and if the tool runs everything successfully, move them to the proper locations. That should be just a matter of renaming the files and the os library gives us os.rename() method. I will implement it and add it to the current PR.

danlabici commented 5 years ago

Everything except the write temp files was been done, closing this Issue and the missing step, which is LOW Priority, can have its own dedicated issue.