search

mozilla-releng / firefox-infra-changelog

Automated tool which builds a changelog of commits happening on git and hg that could affect Firefox CI Infra.
2 stars 8 forks source link

[Git-oop] Multiple returns missing in FIC_Github.py #450

Closed mutterroland closed 5 years ago

mutterroland commented 5 years ago

Looks like every method that saves information in variables is missing the return. I'm not sure if the return is mandatory, but, looking into FIC_Mercurial.py the return may or may not be mandatory. Will make a patch for that and I'm waiting for your opinions as well.

mutterroland commented 5 years ago

https://github.com/mozilla-releng/firefox-infra-changelog/commit/0362dec0c549cb63df1d2d95d0aa2da4d3497787

bccrisan commented 5 years ago

Merged and can be closed for now.