Open danlabici opened 5 years ago
Regards cleaning FICMercurial
:
Do we still need changeset_index
, commit_author
and so on from FICDataVault
into FicMercurial
class? I mean everything is built within the class without using those attributes. We can still build methods that will return a value each time it is called inside the loop that builds the final .json file but does that makes a difference?
Example:
self.commit_author = self.changesets_json.get("pushes").get(push).get("changesets")[commit]["author"]
return self.commit_author```
As we reach the end of development, we need to implement some cleaning strategy for our
Git
andMercurial
objects.An example of proprieties with don't need (in each object) is:
This needs to be implemented as a method in each class. At the end, we only want a clean (and focused) object that has only the data we actually care about.