[Mercurial] Code Improvements

mozilla-releng / firefox-infra-changelog

Automated tool which builds a changelog of commits happening on git and hg that could affect Firefox CI Infra.

2 stars 8 forks source link

[Mercurial] Code Improvements #461

Closed zsoltfay closed 5 years ago

zsoltfay commented 5 years ago

At the moment _construct_json_dict(self) is large and complex. It should be split up into smaller methods which are easier to read and understand. Each small method could perform one task as described:

prepare the final_dict dictionary to accept data
get the local json data(if any)
iterate through the new changesets and retrieve their data
iterate through the commits of each changesets and save wanted data

bccrisan commented 5 years ago

Implemented and the code has been merged. Please reopen if it's something else needed to do.