mozilla-releng / scriptworker-scripts

Mozilla Public License 2.0
13 stars 28 forks source link

feat(beetmover): Support expiration tag for GCS artifacts #1037

Closed hneiva closed 3 months ago

hneiva commented 3 months ago

Yeah adding more tests is a great idea.

I've already tested this in a staging release: treeherder, Example task, gcloud bucket files&project=moz-fx-productdelivery-no-7d6a)

I don't think we have a use case for other schemas yet; but if we do, adding it would be quite easy. Agree we should do it on a follow-up.

bhearsum commented 3 months ago

I've already tested this in a staging release: treeherder, Example task, gcloud bucket files&project=moz-fx-productdelivery-no-7d6a)

Thanks! I will take a look there.

I don't think we have a use case for other schemas yet; but if we do, adding it would be quite easy. Agree we should do it on a follow-up.

I agree we don't need to do it now unless we have specific plans for cleanup of artifacts that are uploaded through those methods already.

hneiva commented 3 months ago

build/ is part of .gitignore - had to force add to make sure the file was added ¯_(ツ)_/¯