search

mozilla-releng / shipit

Ship It API & Frontend
10 stars 26 forks source link

Logged-in user name displayed twice #189

Open srfraser opened 4 years ago

srfraser commented 4 years ago

Screenshot 2020-03-10 at 12 26 47

rail commented 4 years ago

The first one is the avatar's alt text, the second one is the text. Does refreshing help?

srfraser commented 4 years ago

Refreshing doesn't help, it happens every time I view the page

rail commented 4 years ago

Do you see something weird in the JS console? Filtering by "gravatar" may help.

srfraser commented 4 years ago

ah ha. Content Security Policy: The page’s settings blocked the loading of a resource at https://i2.wp.com/cdn.auth0.com/avatars/sf.png?ssl=1 (“img-src”).

https://github.com/mozilla-releng/shipit/blob/master/frontend/scripts/deploy#L11 does not contain i2.wp.com

It may be that if I have a gravatar set it doesn't redirect to that page. I don't, though, and loading the image just shows 'SF' in a square.

bhearsum commented 4 years ago

This is a recurring issue for avatars. This is what we currently have for Balrog:

img-src 'self' https://*.gravatar.com https://*.githubusercontent.com https://i1.wp.com

...which is clearly out of date as well.

rail commented 4 years ago

booo gravatar, booo

bhearsum commented 4 years ago

Note: not all auth0 avatars are from gravatar. Some come from github, some from other places. I don't really understand why.

rail commented 4 years ago

Probably it depends on the auth plugin?