blackify

[catlee]

blackified all the code, and added a check to ensure the code formatting stays consistent.

Moved all the test code and data out of signingscript/test and into a tests/ directory. I also changed how fixtures are getting imported, and removed our custom tmpdir fixture.

Moved all of the application code from signingscript into src/signingscript

There should be no functional differences.

[coveralls]

Coverage remained the same at 100.0% when pulling 339e7022ebcb2da6cd1da2dfc933aecc5b3e359a on catlee:black into 7a909adaf0bbb056d70527d4900c4ff2b5902fa3 on mozilla-releng:master.

[escapewindow]

Hm. Any reason we didn't do black as its own PR? This is doable, but it'll be a more in-depth review.

[catlee]

Hm. Any reason we didn't do black as its own PR? This is doable, but it'll be a more in-depth review.

Sure. I've split out the other patches into another branch. Will submit a PR after.

[escapewindow]

Hm, I'm getting a big diff when I run black . in signingscript/. (toplevel) on revision bfebb0b4e8dc54de644aed785ac938cabbcf45ad and diffing it against your PR?

[catlee]

I excluded the vendor library. Maybe that's it?

On Thu, Sep 5, 2019, 18:52 Aki Sasaki, notifications@github.com wrote:

Hm, I'm getting a big diff when I run black . in signingscript/. (toplevel) on revision bfebb0b4e8dc54de644aed785ac938cabbcf45ad and diffing it against your PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla-releng/signingscript/pull/133?email_source=notifications&email_token=AAANJOQE32K2Y2ZPQXWZ37DQIGESJA5CNFSM4IT7K222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6BCIKA#issuecomment-528622632, or mute the thread https://github.com/notifications/unsubscribe-auth/AAANJOQYB3JXH76FOOQ6Q63QIGESJANCNFSM4IT7K22Q .

[escapewindow]

I don't think so? diff

10128$ grep '^diff' x | grep -v vendored
diff --git a/setup.py b/setup.py
diff --git a/signingscript/createprecomplete.py b/signingscript/createprecomplete.py
diff --git a/signingscript/exceptions.py b/signingscript/exceptions.py
diff --git a/signingscript/script.py b/signingscript/script.py
diff --git a/signingscript/sign.py b/signingscript/sign.py
diff --git a/signingscript/test/__init__.py b/signingscript/test/__init__.py
diff --git a/signingscript/test/integration/__init__.py b/signingscript/test/integration/__init__.py
diff --git a/signingscript/test/integration/test_autograph.py b/signingscript/test/integration/test_autograph.py
diff --git a/signingscript/test/test_exceptions.py b/signingscript/test/test_exceptions.py
diff --git a/signingscript/test/test_script.py b/signingscript/test/test_script.py
diff --git a/signingscript/test/test_task.py b/signingscript/test/test_task.py
diff --git a/signingscript/test/test_utils.py b/signingscript/test/test_utils.py
diff --git a/signingscript/utils.py b/signingscript/utils.py