search

mozilla-releng / signingscript

Signing script to run in scriptworker.
1 stars 11 forks source link

bug 1472860 - catch ClientError and continue during token requests #62

Closed escapewindow closed 6 years ago

escapewindow commented 6 years ago

This fix should allow us to request tokens from the next suitable server, if and when we hit a network issue requesting a token.

@JohanLorenzo do you or @Callek feel comfortable reviewing this? If not we can wait for the Canadians to get back online :)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 15fe20006c2a2f9208657c9dfe79948e8d87baa9 on escapewindow:token-retry into e6a4a400dc4826077dad8764328c05c3a8a7684a on mozilla-releng:master.

Callek commented 6 years ago

@escapewindow also would be good to see tests that ensure that a other tokens are checked in each of these exception cases. (not sure how hard that is to add into the test suite, or if you feel its overkill)