search

mozilla-releng / signingscript

Signing script to run in scriptworker.
1 stars 11 forks source link

Bug 1501453 - Support .msi signing in signingscript #84

Closed Callek closed 6 years ago

Callek commented 6 years ago

This also will now raise an error if there are no files to sign.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7aa7476ef4b76a73c25a78b7d0d3eb9fb39bb50a on Callek:msi_support into eb321067005541f3fcdf65e9375aef7f4f20ff5f on mozilla-releng:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ca1971db16a8283ea74cd681b9a5fe042f4f5695 on Callek:msi_support into eb321067005541f3fcdf65e9375aef7f4f20ff5f on mozilla-releng:master.

escapewindow commented 6 years ago

We may want to allow for signing a windows zip to be idempotent. If we ask for a signed zip to be re-signed currently, we allow it. If we land this PR, asking for it to be re-signed will error out. If we do allow for a valid no-files-to-sign task, then we should probably log.info that fact.