Strip existing APK signature

mozilla-releng / signingscript

Signing script to run in scriptworker.

1 stars 11 forks source link

Strip existing APK signature #86

Closed JohanLorenzo closed 6 years ago

JohanLorenzo commented 6 years ago

Fixes #82

Depends on #85

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 06fda016a5fb3a0ddb63cdc69d437d6a00e88f52 on JohanLorenzo:strip-apk-sig into 2dfd227db34e8b6d1a0a9ed8cd09095aa9875711 on mozilla-releng:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 1bcec2a757f8c73a559cf0bfca0633b1563af7a1 on JohanLorenzo:strip-apk-sig into 817fa5d19fd697081de2ea05c5b6308a64c92969 on mozilla-releng:master.

escapewindow commented 6 years ago

@JohanLorenzo the travis bustage is due to #80; we should fix up #85 to green.

JohanLorenzo commented 6 years ago

Oh that's right! I should have thought of it yesterday. Then, the PR is fixed. I'm okay to close it in favor of #83 if this approach makes more sense.

JohanLorenzo commented 6 years ago

It worked with the latest nightly on https://queue.taskcluster.net/v1/task/ARmkAT3pTx-UcvrNdGF6Jg/runs/0/artifacts/public/app-focus-arm-nightly-unsigned.apk. (I pinned the worker to my end).

Landing the PR.

JohanLorenzo commented 6 years ago

This was deployed and used by Focus after https://github.com/mozilla-releng/build-puppet/pull/280 landed.