search

mozilla-releng / signingscript

Signing script to run in scriptworker.
1 stars 11 forks source link

Bug 1492245 - enable custom signing formats for APK #89

Closed MihaiTabara closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 21aac2da61233cd2abb58655cf37f1c2a15e0229 on MihaiTabara:1492245 into 47d2a1aa241c37fee1e077b0f8e952b1f10a39ad on mozilla-releng:master.

MihaiTabara commented 6 years ago

This is to enable signingscript to handle different digests. Support was added in Autograph but not yet deployed (Tracking item in https://github.com/mozilla-services/autograph/pull/166 ). Once this is landed, the autograph_fennec_sha* scopes would determine signingscript to add that extra argument. It's currently ignored by Autograph until the next deployment. Once that happens, it should pick it up and provide SHA1 digests within the Fennec APKs.

I'll wipe off the test as well and replace that with an integration test once the new deployment is picked up in .travis.yml as well.

MihaiTabara commented 6 years ago

@JohanLorenzo I think this is ready for review, following your IRC instructions from last week in which we currently focus on a single digest format as all our Fennec APKs are currently SHA1.